Remove DhApiResult.createFail() to prevent empty error messages

2023-10-13 19:56:55 -05:00
parent 4b14fe82e7
commit c724c6211e
1 changed files with 1 additions and 1 deletions
@@ -63,7 +63,7 @@ public class DhApiResult<T>
 	// There is no createSuccess(String message) method because it would be too easy to confuse with createSuccess(Pt payload) when returning null
 	public static <Pt> DhApiResult<Pt> createSuccess(String message, Pt payload) { return new DhApiResult<Pt>(true, message, payload); }
 	
-	public static <Pt> DhApiResult<Pt> createFail() { return new DhApiResult<>(false, ""); }
+	// there is no createFail() since all fail results should give a reason for their failure
 	public static <Pt> DhApiResult<Pt> createFail(String message) { return new DhApiResult<>(false, message); }
 	public static <Pt> DhApiResult<Pt> createFail(String message, Pt payload) { return new DhApiResult<Pt>(false, message, payload); }