From c724c6211e0ba6ed819b4e2ad2f4a39b7eb9459d Mon Sep 17 00:00:00 2001
From: James Seibel <jeseibel@gondtc.com>
Date: Fri, 13 Oct 2023 19:56:55 -0500
Subject: [PATCH] Remove DhApiResult.createFail() to prevent empty error
 messages

---
 .../com/seibel/distanthorizons/api/objects/DhApiResult.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/api/src/main/java/com/seibel/distanthorizons/api/objects/DhApiResult.java b/api/src/main/java/com/seibel/distanthorizons/api/objects/DhApiResult.java
index da33f23a4..9d84ca0de 100644
--- a/api/src/main/java/com/seibel/distanthorizons/api/objects/DhApiResult.java
+++ b/api/src/main/java/com/seibel/distanthorizons/api/objects/DhApiResult.java
@@ -63,7 +63,7 @@ public class DhApiResult<T>
 	// There is no createSuccess(String message) method because it would be too easy to confuse with createSuccess(Pt payload) when returning null
 	public static <Pt> DhApiResult<Pt> createSuccess(String message, Pt payload) { return new DhApiResult<Pt>(true, message, payload); }
 	
-	public static <Pt> DhApiResult<Pt> createFail() { return new DhApiResult<>(false, ""); }
+	// there is no createFail() since all fail results should give a reason for their failure
 	public static <Pt> DhApiResult<Pt> createFail(String message) { return new DhApiResult<>(false, message); }
 	public static <Pt> DhApiResult<Pt> createFail(String message, Pt payload) { return new DhApiResult<Pt>(false, message, payload); }