clean up more TODO comments

This commit is contained in:
James Seibel
2026-01-30 07:49:24 -06:00
parent a9bfc3fbe1
commit 9cbe98f81b
4 changed files with 9 additions and 8 deletions
@@ -154,7 +154,7 @@ public class LodDataBuilder
IBlockStateWrapper currentBlockState = AIR;
int mappedId = dataSource.mapping.addIfNotPresentAndGetId(currentBiome, currentBlockState);
// Determine lighting (we are at the height limit. There are no torches here, and sky is not obscured.) // TODO: Per face lighting someday?
// Determine lighting (we are at the height limit. There are no torches here, and sky is not obscured.)
byte blockLight = LodUtil.MIN_MC_LIGHT;
byte skyLight = LodUtil.MAX_MC_LIGHT;
@@ -321,8 +321,6 @@ public class LodDataBuilder
LongArrayList packedDataPoints = convertApiDataPointListToPackedLongArray(columnDataPoints, dataSource, apiChunk.bottomYBlockPos, runAdditionalValidation);
// TODO add the ability for API users to define a different compression mode
// or add a "unkown" compression mode
dataSource.setSingleColumn(
packedDataPoints,
relBlockX + relSourceBlockX, relBlockZ + relSourceBlockZ,
@@ -658,8 +658,6 @@ public class LodQuadTree extends QuadTree<LodRenderSection> implements IDebugRen
}
private void loadQueuedSections(DhBlockPos2D playerPos, HashSet<LodRenderSection> nodesNeedingLoading)
{
// TODO disable world gen while any tasks exist here to speed up loading speed
ArrayList<LodRenderSection> loadSectionList = new ArrayList<>(nodesNeedingLoading);
loadSectionList.sort((LodRenderSection a, LodRenderSection b) ->
{
@@ -290,6 +290,9 @@ public class DhRepoSqliteTest
//===================//
// leaked statements //
//===================//
// don't run these tests in release, leaks aren't tracked and the test will fail
if (AutoClosableTrackingWrapper.TRACK_WRAPPERS)
{
// nuke the DB so we can insert without worries
primaryKeyRepo.deleteAll();
@@ -307,7 +310,6 @@ public class DhRepoSqliteTest
}
}
// TODO fails when built for release due to tracking being disabled
Assert.assertNotEquals(0, primaryKeyRepo.openClosables.size());
primaryKeyRepo.openClosables.clear();
+5 -2
View File
@@ -227,7 +227,10 @@ public class QuadTreeTest
// small move //
DhBlockPos2D smallMoveBlockPos = new DhBlockPos2D(pseudoRootNodeWidthInBlocks * 2, 0); // move enough that the original root nodes aren't touching the same grid squares they were before, but not far enough as to be garbage collected (TODO reword)
// move far enough that the original root nodes aren't touching the same grid
// squares they were before, but not far enough as to be garbage collected
DhBlockPos2D smallMoveBlockPos = new DhBlockPos2D(pseudoRootNodeWidthInBlocks * 2, 0);
tree.setCenterBlockPos(smallMoveBlockPos);
Assert.assertEquals("Tree center incorrect", smallMoveBlockPos, tree.getCenterBlockPos());
@@ -417,7 +420,7 @@ public class QuadTreeTest
}
private static <T> void assertFilterCount(QuadTree<T> tree, String message, int expectedNodeCount, @Nullable QuadTree.INodeIteratorStoppingFunc<T> stoppingFilterFunc) // TODO functional interface
private static <T> void assertFilterCount(QuadTree<T> tree, String message, int expectedNodeCount, @Nullable QuadTree.INodeIteratorStoppingFunc<T> stoppingFilterFunc)
{
ArrayList<String> foundNodePositionStrings = new ArrayList<>();