diff --git a/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/transformers/LodDataBuilder.java b/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/transformers/LodDataBuilder.java index 2328f783e..7ab73e4d8 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/transformers/LodDataBuilder.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/transformers/LodDataBuilder.java @@ -154,7 +154,7 @@ public class LodDataBuilder IBlockStateWrapper currentBlockState = AIR; int mappedId = dataSource.mapping.addIfNotPresentAndGetId(currentBiome, currentBlockState); - // Determine lighting (we are at the height limit. There are no torches here, and sky is not obscured.) // TODO: Per face lighting someday? + // Determine lighting (we are at the height limit. There are no torches here, and sky is not obscured.) byte blockLight = LodUtil.MIN_MC_LIGHT; byte skyLight = LodUtil.MAX_MC_LIGHT; @@ -321,8 +321,6 @@ public class LodDataBuilder LongArrayList packedDataPoints = convertApiDataPointListToPackedLongArray(columnDataPoints, dataSource, apiChunk.bottomYBlockPos, runAdditionalValidation); - // TODO add the ability for API users to define a different compression mode - // or add a "unkown" compression mode dataSource.setSingleColumn( packedDataPoints, relBlockX + relSourceBlockX, relBlockZ + relSourceBlockZ, diff --git a/core/src/main/java/com/seibel/distanthorizons/core/render/QuadTree/LodQuadTree.java b/core/src/main/java/com/seibel/distanthorizons/core/render/QuadTree/LodQuadTree.java index 8cdeb75f4..575374524 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/render/QuadTree/LodQuadTree.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/render/QuadTree/LodQuadTree.java @@ -658,8 +658,6 @@ public class LodQuadTree extends QuadTree implements IDebugRen } private void loadQueuedSections(DhBlockPos2D playerPos, HashSet nodesNeedingLoading) { - // TODO disable world gen while any tasks exist here to speed up loading speed - ArrayList loadSectionList = new ArrayList<>(nodesNeedingLoading); loadSectionList.sort((LodRenderSection a, LodRenderSection b) -> { diff --git a/core/src/test/java/tests/DhRepoSqliteTest.java b/core/src/test/java/tests/DhRepoSqliteTest.java index eeb2d4121..782f216d1 100644 --- a/core/src/test/java/tests/DhRepoSqliteTest.java +++ b/core/src/test/java/tests/DhRepoSqliteTest.java @@ -290,6 +290,9 @@ public class DhRepoSqliteTest //===================// // leaked statements // //===================// + + // don't run these tests in release, leaks aren't tracked and the test will fail + if (AutoClosableTrackingWrapper.TRACK_WRAPPERS) { // nuke the DB so we can insert without worries primaryKeyRepo.deleteAll(); @@ -307,7 +310,6 @@ public class DhRepoSqliteTest } } - // TODO fails when built for release due to tracking being disabled Assert.assertNotEquals(0, primaryKeyRepo.openClosables.size()); primaryKeyRepo.openClosables.clear(); diff --git a/core/src/test/java/tests/QuadTreeTest.java b/core/src/test/java/tests/QuadTreeTest.java index 4613a3869..a99884eca 100644 --- a/core/src/test/java/tests/QuadTreeTest.java +++ b/core/src/test/java/tests/QuadTreeTest.java @@ -227,7 +227,10 @@ public class QuadTreeTest // small move // - DhBlockPos2D smallMoveBlockPos = new DhBlockPos2D(pseudoRootNodeWidthInBlocks * 2, 0); // move enough that the original root nodes aren't touching the same grid squares they were before, but not far enough as to be garbage collected (TODO reword) + + // move far enough that the original root nodes aren't touching the same grid + // squares they were before, but not far enough as to be garbage collected + DhBlockPos2D smallMoveBlockPos = new DhBlockPos2D(pseudoRootNodeWidthInBlocks * 2, 0); tree.setCenterBlockPos(smallMoveBlockPos); Assert.assertEquals("Tree center incorrect", smallMoveBlockPos, tree.getCenterBlockPos()); @@ -417,7 +420,7 @@ public class QuadTreeTest } - private static void assertFilterCount(QuadTree tree, String message, int expectedNodeCount, @Nullable QuadTree.INodeIteratorStoppingFunc stoppingFilterFunc) // TODO functional interface + private static void assertFilterCount(QuadTree tree, String message, int expectedNodeCount, @Nullable QuadTree.INodeIteratorStoppingFunc stoppingFilterFunc) { ArrayList foundNodePositionStrings = new ArrayList<>();