wisplite/distant-horizons-sharded
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix buffer upload breaking UI on old MC versions

Browse Source
This commit is contained in:
James Seibel
2026-04-17 07:49:04 -05:00
parent e68b112020
commit a1af4335e0
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/src/main/java/com/seibel/distanthorizons/common/render/openGl/glObject/buffer/GLBuffer.java
+9 -4
View File
@@ -210,9 +210,12 @@ public class GLBuffer implements AutoCloseable
// re-binding the old VBO is necessary for old MC versions (IE 1.16.5 and older)
// otherwise the screen may be black when on the home menu
int previousBoundVbo = GL32.glGetInteger(GL32.GL_ARRAY_BUFFER_BINDING);
// re-binding the old buffers is necessary for old MC versions for the following reasons:
// for 16.5 and older the screen may be black when on the home menu
// and for 1.19.2 - 1.21.4 the inventory/UI will render without a background
int vao = GL32.glGetInteger(GL32.GL_VERTEX_ARRAY_BINDING);
int vbo = GL32.glGetInteger(GL32.GL_ARRAY_BUFFER_BINDING);
int ebo = GL32.glGetInteger(GL32.GL_ELEMENT_ARRAY_BUFFER_BINDING);
try
{
@@ -238,7 +241,9 @@ public class GLBuffer implements AutoCloseable
}
finally
{
GL32.glBindBuffer(GL32.GL_ARRAY_BUFFER, GL32.glIsBuffer(previousBoundVbo) ? previousBoundVbo : 0);
GL32.glBindVertexArray(GL32.glIsVertexArray(vao) ? vao : 0);
GL32.glBindBuffer(GL32.GL_ARRAY_BUFFER, GL32.glIsBuffer(vbo) ? vbo : 0);
GL32.glBindBuffer(GL32.GL_ELEMENT_ARRAY_BUFFER, GL32.glIsBuffer(ebo) ? ebo: 0);
}
}
/** Requires the buffer to be bound */