Improve formating and extract a constant

This commit is contained in:
James Seibel
2020-10-06 11:02:31 -05:00
parent 66febf3e61
commit 553abf1c75
@@ -16,10 +16,13 @@ import net.minecraft.world.chunk.storage.ExtendedBlockStorage;
* and color data for an LOD object.
*
* @author James Seibel
* @version 09-29-2020
* @version 10-06-2020
*/
public class LodChunk
{
/** how many different pieces of data are in one line */
private static final int DATA_DELIMITER_COUNT = 28;
/** This is what separates each piece of data in the toData method */
public static final char DATA_DELIMITER = ',';
@@ -53,6 +56,16 @@ public class LodChunk
//==============//
// constructors //
//==============//
public LodChunk()
{
x = 0;
@@ -120,7 +133,7 @@ public class LodChunk
/**
* Creates an LodChunk from the string
* created by the toData method.
* generated by the toData method.
*
* @throws IllegalArgumentException if the data isn't valid to create a LodChunk
* @throws NumberFormatException if the data can't be converted into an int at any point
@@ -135,8 +148,6 @@ public class LodChunk
* 5,8, 4,4,4,4, 0,0,0,0, 255,255,255, 255,255,255, 255,255,255, 255,255,255, 255,255,255, 255,255,255,
*/
// make sure there are the correct number of entries
// in the data string (28)
int count = 0;
@@ -149,9 +160,9 @@ public class LodChunk
}
}
if(count != 28)
if(count != DATA_DELIMITER_COUNT)
{
throw new IllegalArgumentException("LodChunk constructor givin an invalid string. The data given had " + count + " delimiters when it should have had 28.");
throw new IllegalArgumentException("LodChunk constructor givin an invalid string. The data given had " + count + " delimiters when it should have had " + DATA_DELIMITER_COUNT + ".");
}
@@ -222,6 +233,17 @@ public class LodChunk
}
//=====================//
// constructor helpers //
//=====================//
/**
* If invalid/null/empty chunks are given
* crashes may occur.
@@ -486,6 +508,20 @@ public class LodChunk
//========//
// output //
//========//
/**
* Outputs all data in csv format
* with the given delimiter.