Remove several TODOs
This commit is contained in:
-4
@@ -29,10 +29,6 @@ public class MixinChunkMapCommon
|
||||
return;
|
||||
}
|
||||
|
||||
// TODO are the following validations necessary since we are checking above if
|
||||
// the callback return value should state if the chunk was actually saved or not?
|
||||
// Do we trust it to always be correct?
|
||||
|
||||
|
||||
|
||||
// corrupt/incomplete chunk validation //
|
||||
|
||||
-1
@@ -258,7 +258,6 @@ public class BiomeWrapper implements IBiomeWrapper
|
||||
return this.serialString;
|
||||
}
|
||||
|
||||
// TODO would it be worth while to cache these objects in a ConcurrentHashMap<string, IBiomeWrapper>?
|
||||
public static IBiomeWrapper deserialize(String resourceLocationString, ILevelWrapper levelWrapper) throws IOException
|
||||
{
|
||||
// we need the final string for the concurrent hash map later
|
||||
|
||||
+1
-1
@@ -322,7 +322,7 @@ public class ClientBlockStateColorCache
|
||||
return quads;
|
||||
}
|
||||
|
||||
//TODO: Perhaps make this not just use the first frame?
|
||||
/** if multiple frames are present, just the first one will be used */
|
||||
private static int calculateColorFromTexture(TextureAtlasSprite texture, EColorMode colorMode)
|
||||
{
|
||||
int count = 0;
|
||||
|
||||
+4
-3
@@ -371,7 +371,6 @@ public class ChunkWrapper implements IChunkWrapper
|
||||
blockPos.setY(relY);
|
||||
blockPos.setZ(relZ);
|
||||
|
||||
// TODO copy into pooled array, this isn't thread safe and can cause MC to throw errors if the chunk is loaded
|
||||
return BlockStateWrapper.fromBlockState(this.chunk.getBlockState(blockPos), this.wrappedLevel);
|
||||
}
|
||||
|
||||
@@ -413,8 +412,10 @@ public class ChunkWrapper implements IChunkWrapper
|
||||
LevelChunkSection section = sections[i];
|
||||
if (section != null)
|
||||
{
|
||||
// TODO implement section cloning for older MC versions, only 1.21.4 MC (and maybe other semi recent versions) have a clean way to handle this
|
||||
// TODO we probably want a wrapper object instead
|
||||
// Implementation notes:
|
||||
// implement section cloning for older MC versions, only 1.21.4 MC (and maybe other semi recent versions) have a clean way to handle this
|
||||
// we probably want a wrapper object instead
|
||||
|
||||
#if MC_VER < MC_1_21_4
|
||||
this.levelChunkSections[i] = section;
|
||||
#else
|
||||
|
||||
-2
@@ -37,8 +37,6 @@ import java.util.*;
|
||||
*
|
||||
* @author coolGi
|
||||
*/
|
||||
// TODO: After finishing the config, rewrite this in openGL as well
|
||||
// TODO: Make this
|
||||
public class ChangelogScreen extends DhScreen
|
||||
{
|
||||
private static final DhLogger LOGGER = new DhLoggerBuilder().build();
|
||||
|
||||
+4
-4
@@ -52,7 +52,7 @@ public class LightMapWrapper implements ILightMapWrapper
|
||||
|
||||
public void uploadLightmap(NativeImage image)
|
||||
{
|
||||
#if MC_VER < MC_1_21_5
|
||||
#if MC_VER < MC_1_21_3
|
||||
int currentTexture = GLMC.getActiveTexture();
|
||||
if (this.textureId == 0)
|
||||
{
|
||||
@@ -71,18 +71,18 @@ public class LightMapWrapper implements ILightMapWrapper
|
||||
GLMC.glBindTexture(currentTexture);
|
||||
}
|
||||
#else
|
||||
throw new UnsupportedOperationException("setLightmapId should be used for MC versions after 1.21.5"); // TODO that MC version number is wrong, when did we actually start using setLightmapId()?
|
||||
throw new UnsupportedOperationException("setLightmapId should be used for MC versions after 1.21.3");
|
||||
#endif
|
||||
}
|
||||
private void createLightmap(NativeImage image)
|
||||
{
|
||||
#if MC_VER < MC_1_21_5
|
||||
#if MC_VER < MC_1_21_3
|
||||
this.textureId = GLMC.glGenTextures();
|
||||
GLMC.glBindTexture(this.textureId);
|
||||
GL32.glTexImage2D(GL32.GL_TEXTURE_2D, 0, image.format().glFormat(), image.getWidth(), image.getHeight(),
|
||||
0, image.format().glFormat(), GL32.GL_UNSIGNED_BYTE, (ByteBuffer) null);
|
||||
#else
|
||||
throw new UnsupportedOperationException("setLightmapId should be used for MC versions after 1.21.5"); // TODO that MC version number is wrong, when did we actually start using setLightmapId()?
|
||||
throw new UnsupportedOperationException("setLightmapId should be used for MC versions after 1.21.3");
|
||||
#endif
|
||||
}
|
||||
|
||||
|
||||
-7
@@ -216,13 +216,6 @@ public class DhLitWorldGenRegion extends WorldGenRegion
|
||||
public LevelTickAccess<Fluid> getFluidTicks() { return BlackholeTickAccess.emptyLevelList(); }
|
||||
#endif
|
||||
|
||||
// TODO Check this
|
||||
// @Override
|
||||
// public List<? extends StructureStart<?>> startsForFeature(SectionPos sectionPos,
|
||||
// StructureFeature<?> structureFeature) {
|
||||
// return structFeat.startsForFeature(sectionPos, structureFeature);
|
||||
// }
|
||||
|
||||
// Skip updating the related tile entities
|
||||
@Override
|
||||
public boolean setBlock(BlockPos blockPos, BlockState blockState, int i, int j)
|
||||
|
||||
Reference in New Issue
Block a user