re-add chat warning if G1GC is used
This commit is contained in:
@@ -21,9 +21,11 @@ package com.seibel.distanthorizons.core;
|
||||
|
||||
import com.github.luben.zstd.ZstdOutputStream;
|
||||
import com.seibel.distanthorizons.api.methods.events.abstractEvents.DhApiBeforeRenderEvent;
|
||||
import com.seibel.distanthorizons.core.api.internal.ClientApi;
|
||||
import com.seibel.distanthorizons.core.config.Config;
|
||||
import com.seibel.distanthorizons.core.config.eventHandlers.IgnoredDimensionCsvHandler;
|
||||
import com.seibel.distanthorizons.core.dependencyInjection.SingletonInjector;
|
||||
import com.seibel.distanthorizons.core.enums.MinecraftTextFormat;
|
||||
import com.seibel.distanthorizons.core.logging.DhLoggerBuilder;
|
||||
import com.seibel.distanthorizons.core.render.renderer.generic.GenericRenderObjectFactory;
|
||||
import com.seibel.distanthorizons.core.sql.DatabaseUpdater;
|
||||
@@ -160,16 +162,31 @@ public class Initializer
|
||||
LOGGER.info("Garbage collectors: ["+garbageCollectorNames+"]");
|
||||
|
||||
|
||||
if (g1GcInUse
|
||||
&& Config.Common.Logging.Warning.logGarbageCollectorWarning.get())
|
||||
if (g1GcInUse)
|
||||
{
|
||||
LOGGER.warn(
|
||||
"Distant Horizons: G1 Garbage collector detected. \n" +
|
||||
"This garbage collector can cause FPS stuttering. \n" +
|
||||
String warningMessageHeader = "Distant Horizons: G1 Garbage collector detected.";
|
||||
String warningMessageBody =
|
||||
"This can cause FPS stuttering. \n" +
|
||||
"It's recommended to use a concurrent garbage collector \n" +
|
||||
"like ZGC (Java 21+) or Shenandoah (Java 8 through 17) for a smoother experience. \n" +
|
||||
"");
|
||||
"like ZGC (Java 21+) or Shenandoah (Java 8 through 17) \n" +
|
||||
"for a smoother experience."
|
||||
;
|
||||
|
||||
if (Config.Common.Logging.Warning.logGarbageCollectorWarning.get())
|
||||
{
|
||||
LOGGER.warn(
|
||||
warningMessageHeader + "\n" +
|
||||
warningMessageBody +
|
||||
"");
|
||||
}
|
||||
|
||||
if (Config.Common.Logging.Warning.showGarbageCollectorWarning.get())
|
||||
{
|
||||
ClientApi.INSTANCE.showChatMessageNextFrame(
|
||||
MinecraftTextFormat.ORANGE + warningMessageHeader + MinecraftTextFormat.CLEAR_FORMATTING + "\n" +
|
||||
warningMessageBody +
|
||||
"");
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1646,7 +1646,16 @@ public class Config
|
||||
.comment(""
|
||||
+ "If enabled, a message will be logged if the garbage \n"
|
||||
+ "collector Java is currently using is known \n"
|
||||
+ "to cause stutters and/or issues. \n"
|
||||
+ "to cause frame stuttering and/or other issues. \n"
|
||||
+ "")
|
||||
.build();
|
||||
|
||||
public static ConfigEntry<Boolean> showGarbageCollectorWarning = new ConfigEntry.Builder<Boolean>()
|
||||
.set(true)
|
||||
.comment(""
|
||||
+ "If enabled, a chat message will be displayed if the garbage \n"
|
||||
+ "collector Java is currently using is known \n"
|
||||
+ "to cause frame stuttering and/or other issues. \n"
|
||||
+ "")
|
||||
.build();
|
||||
|
||||
|
||||
@@ -748,6 +748,8 @@
|
||||
"Show Slow World Gen Warnings",
|
||||
"distanthorizons.config.common.logging.warning.showModCompatibilityWarningsOnStartup":
|
||||
"Show Mod Compatibility Warnings",
|
||||
"distanthorizons.config.common.logging.warning.showGarbageCollectorWarning":
|
||||
"Show Garbage Collector Warning",
|
||||
"distanthorizons.config.common.logging.warning.logGarbageCollectorWarning":
|
||||
"Log Garbage Collector Warning",
|
||||
|
||||
|
||||
Reference in New Issue
Block a user