wisplite/distant-horizons-core-sharded
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make ThreadUtil return ThreadPoolExecutor's instead of ExecutorService's

Browse Source 
This was what was already being done by the Executors.newFixedThreadPool() method we were using; but this change means we don't have to cast the executors if we need additional functionality and we don't have to worry about Java changing Executors.newFixedThreadPool()'s implementation.
This commit is contained in:
James Seibel
2023-07-15 11:34:55 -05:00
parent f3414ed73d
commit 2ead289ade
1 changed files with 16 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/com/seibel/distanthorizons/core/util/ThreadUtil.java
+16 -11
View File
@@ -2,8 +2,7 @@ package com.seibel.distanthorizons.core.util;
import com.seibel.distanthorizons.core.util.objects.DhThreadFactory;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.*;
public class ThreadUtil
{
@@ -16,20 +15,26 @@ public class ThreadUtil
// create thread pool //
public static ExecutorService makeThreadPool(int poolSize, String name, int relativePriority)
public static ThreadPoolExecutor makeThreadPool(int poolSize, String name, int relativePriority)
{
return Executors.newFixedThreadPool(poolSize, new DhThreadFactory("DH-" + name, Thread.NORM_PRIORITY+relativePriority));
// this is what was being internally used by Executors.newFixedThreadPool
// I'm just calling it explicitly here so we can reference the more feature-rich
// ThreadPoolExecutor vs the more generic ExecutorService
return new ThreadPoolExecutor(/*corePoolSize*/poolSize, /*maxPoolSize*/poolSize,
0L, TimeUnit.MILLISECONDS,
new LinkedBlockingQueue<Runnable>(),
new DhThreadFactory("DH-" + name, Thread.NORM_PRIORITY+relativePriority));
}
public static ExecutorService makeThreadPool(int poolSize, Class<?> clazz, int relativePriority)
public static ThreadPoolExecutor makeThreadPool(int poolSize, Class<?> clazz, int relativePriority)
{
return makeThreadPool(poolSize, clazz.getSimpleName(), relativePriority);
}
public static ExecutorService makeThreadPool(int poolSize, String name)
public static ThreadPoolExecutor makeThreadPool(int poolSize, String name)
{
return makeThreadPool(poolSize, name, 0);
}
public static ExecutorService makeThreadPool(int poolSize, Class<?> clazz)
public static ThreadPoolExecutor makeThreadPool(int poolSize, Class<?> clazz)
{
return makeThreadPool(poolSize, clazz.getSimpleName(), 0);
}
@@ -37,19 +42,19 @@ public class ThreadUtil
// create single thread pool //
public static ExecutorService makeSingleThreadPool(String name, int relativePriority)
public static ThreadPoolExecutor makeSingleThreadPool(String name, int relativePriority)
{
return makeThreadPool(1, name, relativePriority);
}
public static ExecutorService makeSingleThreadPool(Class<?> clazz, int relativePriority)
public static ThreadPoolExecutor makeSingleThreadPool(Class<?> clazz, int relativePriority)
{
return makeThreadPool(1, clazz.getSimpleName(), relativePriority);
}
public static ExecutorService makeSingleThreadPool(String name)
public static ThreadPoolExecutor makeSingleThreadPool(String name)
{
return makeThreadPool(1, name, 0);
}
public static ExecutorService makeSingleThreadPool(Class<?> clazz)
public static ThreadPoolExecutor makeSingleThreadPool(Class<?> clazz)
{
return makeThreadPool(1, clazz.getSimpleName(), 0);
}