refactor album access logic to handle guest users and improve state initialization in gallery components

backend/internal/routes/album.go

@@ -11,10 +11,6 @@ func RegisterAlbumRoutes(rg *gin.RouterGroup) {
 	album := rg.Group("/albums")
 	album.POST("/getAlbumsInParent", func(c *gin.Context) {
 		accessToken := c.GetHeader("Authorization")
-		if accessToken == "" {
-			c.JSON(http.StatusUnauthorized, gin.H{"error": "Unauthorized"})
-			return
-		}
 		var request struct {
 			ParentID string `json:"parentId"`
 		}

backend/internal/services/album.go

@@ -14,17 +14,22 @@ import (
 func GetAlbumsInParent(parentID string, authToken string) ([]models.Album, error) {
 	userID, err := ValidateAccessToken(authToken)
 	if err != nil {
-		return []models.Album{}, err
+		if err != gorm.ErrRecordNotFound { //if record not found, assume user is guest
+			return []models.Album{}, err
+		}
 	}
 	accessLevel, err := CheckUserAlbumAccess(userID, parentID)
 	if err != nil {
-		return []models.Album{}, err
+		if err != gorm.ErrRecordNotFound { //if record not found, assume user is guest
+			return []models.Album{}, err
+		}
+		accessLevel = 1
 	}
-	if accessLevel < 1 {
+	if accessLevel < 0 {
 		return []models.Album{}, fmt.Errorf("user does not have permission to view albums in this parent")
 	}
 	albums := []models.Album{}
-	result := db.GetDB().Where("private = ?", false).Where("parent_id = ?", parentID).Find(&albums)
+	result := db.GetDB().Where("parent_id = ?", parentID).Find(&albums)
 	if result.Error != nil {
 		return []models.Album{}, result.Error
 	}

frontend/src/gallery/components/AlbumList.jsx

@@ -11,48 +11,42 @@ export default function AlbumList({ currentAlbumName }) {
     const [albums, setAlbums] = useState([])
     const navigate = useNavigate()
     const { showError } = useNotifier()
-    const getAlbums = async () => {
+    useEffect(() => {
-        console.log('Getting albums in parent', currentAlbumName)
+        let ignore = false;
-        if (currentAlbumName === 'gallery') { // Root album
+        const getAlbums = async () => {
-            const response = await fetch(`${getServerUrl()}/api/albums/getAlbumsInParent`, {
+            console.log('Getting albums in parent', currentAlbumName)
-                method: 'POST',
+            const parentId = currentAlbumName === 'gallery' ? "" : currentAlbumName;
-                headers: {
+            try {
-                    'Authorization': getAccessToken(),
+                const response = await fetch(`${getServerUrl()}/api/albums/getAlbumsInParent`, {
-                },
+                    method: 'POST',
-                body: JSON.stringify({
+                    headers: {
-                    parentId: "",
+                        'Authorization': getAccessToken(),
-                }),
+                    },
-            })
+                    body: JSON.stringify({
-            const data = await response.json()
+                        parentId: parentId,
-            if (data.error) {
+                    }),
-                setAlbums([])
+                })
-                showError('Failed to get albums')
+                const data = await response.json()
-            } else {
+                if (!ignore) {
-                setAlbums(data)
+                    if (data.error) {
-            }
+                        setAlbums([])
-        } else {
+                        showError('Failed to get albums')
-            const response = await fetch(`${getServerUrl()}/api/albums/getAlbumsInParent`, {
+                    } else {
-                method: 'POST',
+                        setAlbums(data)
-                headers: {
+                    }
-                    'Authorization': getAccessToken(),
+                }
-                },
+            } catch (error) {
-                body: JSON.stringify({
+                if (!ignore) {
-                    parentId: currentAlbumName,
+                    setAlbums([])
-                }),
+                    showError('Failed to get albums')
-            })
+                }
-            const data = await response.json()
-            if (data.error) {
-                setAlbums([])
-                showError('Failed to get albums')
-            } else {
-                setAlbums(data)
             }
         }
-    }
+
-    useEffect(() => {
+        if (!open && currentAlbumName !== null) {
-        if (!open) {
             getAlbums()
         }
+        return () => { ignore = true; }
     }, [currentAlbumName, open])
     return (
         <div className="flex flex-col items-center justify-start h-full w-full bg-[#141414]">

frontend/src/gallery/index.jsx

@@ -9,7 +9,7 @@ export default function Gallery() {
     const currentPath = useLocation().pathname;
     const pathList = currentPath.split('/').slice(1);
     const currentAlbumName = pathList[pathList.length - 1];
-    const [currentAlbumID, setCurrentAlbumID] = useState("!notfound!"); // set to impossible value to prevent client from fetching root album
+    const [currentAlbumID, setCurrentAlbumID] = useState(null); // Initialize as null to prevent premature fetching
     const { fetchUserData, user } = useAccount()
     const { getAccessToken } = useAccount()
     const { showError } = useNotifier()