From eb6aa1381514ee816224c949bb3327a8edc9e77f Mon Sep 17 00:00:00 2001 From: James Seibel Date: Sun, 15 Mar 2026 16:29:48 -0500 Subject: [PATCH] Disable generic rendering on Mac --- .../openGl/generic/GlGenericObjectRenderer.java | 16 ++++++++++++++++ coreSubProjects | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/common/src/main/java/com/seibel/distanthorizons/common/render/openGl/generic/GlGenericObjectRenderer.java b/common/src/main/java/com/seibel/distanthorizons/common/render/openGl/generic/GlGenericObjectRenderer.java index 0fae35b2c..cc2c34530 100644 --- a/common/src/main/java/com/seibel/distanthorizons/common/render/openGl/generic/GlGenericObjectRenderer.java +++ b/common/src/main/java/com/seibel/distanthorizons/common/render/openGl/generic/GlGenericObjectRenderer.java @@ -195,6 +195,13 @@ public class GlGenericObjectRenderer implements IDhGenericRenderer this.vertexAttribDivisorSupported = GLProxy.getInstance().vertexAttribDivisorSupported; this.instancedArraysSupported = GLProxy.getInstance().instancedArraysSupported; boolean isMac = (EPlatform.get() == EPlatform.MACOS); + if (isMac) + { + LOGGER.warn("Generic rendering not supported by Mac. Clouds, beacons, and some other effects will be disabled."); + Config.Client.Advanced.Graphics.GenericRendering.enableGenericRendering.setApiValue(false); + return; + } + this.instancedRenderingAvailable = (this.vertexAttribDivisorSupported || this.instancedArraysSupported) && !isMac; if (!this.instancedRenderingAvailable) { @@ -399,6 +406,14 @@ public class GlGenericObjectRenderer implements IDhGenericRenderer @Override public void render(RenderParams renderEventParam, IProfilerWrapper profiler, boolean renderingWithSsao) { + // generic rendering (both instanced and direct) is extremely unstable on Mac, so don't render anything + if (EPlatform.get() == EPlatform.MACOS) + { + return; + } + + + // render setup // profiler.push("setup"); @@ -511,6 +526,7 @@ public class GlGenericObjectRenderer implements IDhGenericRenderer } + //==========// // clean up // //==========// diff --git a/coreSubProjects b/coreSubProjects index 17df533fa..2de50475f 160000 --- a/coreSubProjects +++ b/coreSubProjects @@ -1 +1 @@ -Subproject commit 17df533fa6fd64a09969486b6775fe9cae0e583c +Subproject commit 2de50475f175003ab4315328dc5f7d38b5fc2bef