From 4dd51022fa67843acbaeff8fdc6c1f1f7d4718c5 Mon Sep 17 00:00:00 2001 From: cola98765 Date: Sun, 12 Dec 2021 00:16:41 +0100 Subject: [PATCH 1/3] attempt to fix generation below y=0 --- .../java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java b/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java index 27bc79177..6393d6916 100644 --- a/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java +++ b/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java @@ -88,6 +88,7 @@ public class ChunkWrapper implements IChunkWrapper @Override public IBlockShapeWrapper getBlockShapeWrapper(int x, int y, int z) { + if (y < 0) y = 0; //TODO replace with value from version specific constants Block block = chunk.getSections()[y >> CHUNK_SECTION_SHIFT].getBlockState(x & CHUNK_SIZE_MASK, y & CHUNK_SECTION_MASK, z & CHUNK_SIZE_MASK).getBlock(); return BlockShapeWrapper.getBlockShapeWrapper(block, this, x, y, z); } From e29ec2dea60bbc5c6dca6be40c0398a0b59ca209 Mon Sep 17 00:00:00 2001 From: cola98765 Date: Sun, 12 Dec 2021 00:23:06 +0100 Subject: [PATCH 2/3] Revert "attempt to fix generation below y=0" This reverts commit 4dd51022fa67843acbaeff8fdc6c1f1f7d4718c5. --- .../java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java b/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java index 6393d6916..27bc79177 100644 --- a/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java +++ b/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java @@ -88,7 +88,6 @@ public class ChunkWrapper implements IChunkWrapper @Override public IBlockShapeWrapper getBlockShapeWrapper(int x, int y, int z) { - if (y < 0) y = 0; //TODO replace with value from version specific constants Block block = chunk.getSections()[y >> CHUNK_SECTION_SHIFT].getBlockState(x & CHUNK_SIZE_MASK, y & CHUNK_SECTION_MASK, z & CHUNK_SIZE_MASK).getBlock(); return BlockShapeWrapper.getBlockShapeWrapper(block, this, x, y, z); } From 6344fcf44c7e6f578032e190d2a3ce3274335e3a Mon Sep 17 00:00:00 2001 From: cola98765 Date: Sun, 12 Dec 2021 00:25:47 +0100 Subject: [PATCH 3/3] attempt to fix generation below y=0 --- .../java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java b/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java index 27bc79177..106475dfd 100644 --- a/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java +++ b/src/main/java/com/seibel/lod/forge/wrappers/chunk/ChunkWrapper.java @@ -49,6 +49,7 @@ public class ChunkWrapper implements IChunkWrapper private final int CHUNK_SECTION_MASK = 0b1111; private final int CHUNK_SIZE_SHIFT = 4; private final int CHUNK_SIZE_MASK = 0b1111; + public static final int MIN_HEIGHT = 0; //TODO move this to specific file @Override public int getHeight()