From 9cd48fb5d7f9dcfe56bdea4dc56f23b7bcb549d3 Mon Sep 17 00:00:00 2001 From: James Seibel Date: Sat, 23 Mar 2024 16:18:40 -0500 Subject: [PATCH] Comment out trace logs These logs aren't printed and will just increase GC pressure for strings --- .../distanthorizons/common/wrappers/block/BiomeWrapper.java | 3 ++- .../common/wrappers/block/BlockStateWrapper.java | 3 ++- coreSubProjects | 2 +- .../com/seibel/distanthorizons/fabric/FabricClientProxy.java | 4 ++-- .../com/seibel/distanthorizons/forge/ForgeClientProxy.java | 4 ++-- .../seibel/distanthorizons/neoforge/NeoforgeClientProxy.java | 4 ++-- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BiomeWrapper.java b/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BiomeWrapper.java index dfec14fc9..d685e36c2 100644 --- a/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BiomeWrapper.java +++ b/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BiomeWrapper.java @@ -121,7 +121,8 @@ public class BiomeWrapper implements IBiomeWrapper this.biome = biome; this.serialString = this.serialize(levelWrapper); this.hashCode = Objects.hash(this.serialString); - LOGGER.trace("Created BiomeWrapper ["+this.serialString+"] for ["+biome+"]"); + + //LOGGER.trace("Created BiomeWrapper ["+this.serialString+"] for ["+biome+"]"); } /** should only be used to create {@link BiomeWrapper#EMPTY_WRAPPER} */ diff --git a/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BlockStateWrapper.java b/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BlockStateWrapper.java index 81362e030..3e3a901dd 100644 --- a/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BlockStateWrapper.java +++ b/common/src/main/java/com/seibel/distanthorizons/common/wrappers/block/BlockStateWrapper.java @@ -124,7 +124,8 @@ public class BlockStateWrapper implements IBlockStateWrapper this.serialString = this.serialize(levelWrapper); this.hashCode = Objects.hash(this.serialString); this.irisBlockMaterialId = this.calculateIrisBlockMaterialId(); - LOGGER.trace("Created BlockStateWrapper ["+this.serialString+"] for ["+blockState+"] with material ID ["+this.irisBlockMaterialId+"]"); + + //LOGGER.trace("Created BlockStateWrapper ["+this.serialString+"] for ["+blockState+"] with material ID ["+this.irisBlockMaterialId+"]"); } diff --git a/coreSubProjects b/coreSubProjects index 4cdc6c963..a1c85d91f 160000 --- a/coreSubProjects +++ b/coreSubProjects @@ -1 +1 @@ -Subproject commit 4cdc6c96323097ad57cb0509f67267666dc2fd11 +Subproject commit a1c85d91fc4c2aa2398f11ffc0f78f1305ad01ab diff --git a/fabric/src/main/java/com/seibel/distanthorizons/fabric/FabricClientProxy.java b/fabric/src/main/java/com/seibel/distanthorizons/fabric/FabricClientProxy.java index bcde63d5b..74d1c262c 100644 --- a/fabric/src/main/java/com/seibel/distanthorizons/fabric/FabricClientProxy.java +++ b/fabric/src/main/java/com/seibel/distanthorizons/fabric/FabricClientProxy.java @@ -130,7 +130,7 @@ public class FabricClientProxy implements AbstractModInitializer.IEventProxy ChunkAccess chunk = level.getChunk(blockPos); if (chunk != null) { - LOGGER.trace("attack block at blockPos: " + blockPos); + //LOGGER.trace("attack block at blockPos: " + blockPos); IClientLevelWrapper wrappedLevel = ClientLevelWrapper.getWrapper((ClientLevel) level); SharedApi.INSTANCE.chunkBlockChangedEvent( @@ -160,7 +160,7 @@ public class FabricClientProxy implements AbstractModInitializer.IEventProxy ChunkAccess chunk = level.getChunk(hitResult.getBlockPos()); if (chunk != null) { - LOGGER.trace("use block at blockPos: " + hitResult.getBlockPos()); + //LOGGER.trace("use block at blockPos: " + hitResult.getBlockPos()); IClientLevelWrapper wrappedLevel = ClientLevelWrapper.getWrapper((ClientLevel) level); SharedApi.INSTANCE.chunkBlockChangedEvent( diff --git a/forge/src/main/java/com/seibel/distanthorizons/forge/ForgeClientProxy.java b/forge/src/main/java/com/seibel/distanthorizons/forge/ForgeClientProxy.java index 9b1b03c49..231368363 100644 --- a/forge/src/main/java/com/seibel/distanthorizons/forge/ForgeClientProxy.java +++ b/forge/src/main/java/com/seibel/distanthorizons/forge/ForgeClientProxy.java @@ -178,7 +178,7 @@ public class ForgeClientProxy implements AbstractModInitializer.IEventProxy return; } - LOGGER.trace("interact or block place event at blockPos: " + event.getPos()); + //LOGGER.trace("interact or block place event at blockPos: " + event.getPos()); #if MC_VER < MC_1_19_2 LevelAccessor level = event.getWorld(); @@ -197,7 +197,7 @@ public class ForgeClientProxy implements AbstractModInitializer.IEventProxy return; } - LOGGER.trace("break or block attack at blockPos: " + event.getPos()); + //LOGGER.trace("break or block attack at blockPos: " + event.getPos()); #if MC_VER < MC_1_19_2 LevelAccessor level = event.getWorld(); diff --git a/neoforge/src/main/java/com/seibel/distanthorizons/neoforge/NeoforgeClientProxy.java b/neoforge/src/main/java/com/seibel/distanthorizons/neoforge/NeoforgeClientProxy.java index 69da1d5e1..b58d758a1 100644 --- a/neoforge/src/main/java/com/seibel/distanthorizons/neoforge/NeoforgeClientProxy.java +++ b/neoforge/src/main/java/com/seibel/distanthorizons/neoforge/NeoforgeClientProxy.java @@ -151,7 +151,7 @@ public class NeoforgeClientProxy implements AbstractModInitializer.IEventProxy return; } - LOGGER.trace("interact or block place event at blockPos: " + event.getPos()); + //LOGGER.trace("interact or block place event at blockPos: " + event.getPos()); LevelAccessor level = event.getLevel(); @@ -166,7 +166,7 @@ public class NeoforgeClientProxy implements AbstractModInitializer.IEventProxy return; } - LOGGER.trace("break or block attack at blockPos: " + event.getPos()); + //LOGGER.trace("break or block attack at blockPos: " + event.getPos()); LevelAccessor level = event.getLevel();