From 3bd1eedcb841ba0585c7c1786887b32b800bb408 Mon Sep 17 00:00:00 2001 From: tom lee Date: Sat, 22 Jan 2022 23:05:11 +0800 Subject: [PATCH] Fixed Lithium WorldGen NullPtr issue cause by lazyness Detail cause: I only override the getChunk(x,y,status,bool) and not its sub set like getChunk(x,y), getChunk(x,y,status) because... Programmer is always lazy. Aren't they? --- .../wrappers/worldGeneration/WorldGenerationStep.java | 10 ++++++++++ fabric/build.gradle | 3 +++ gradle.properties | 1 + 3 files changed, 14 insertions(+) diff --git a/common/src/main/java/com/seibel/lod/common/wrappers/worldGeneration/WorldGenerationStep.java b/common/src/main/java/com/seibel/lod/common/wrappers/worldGeneration/WorldGenerationStep.java index cf59ff35e..17b5f1987 100644 --- a/common/src/main/java/com/seibel/lod/common/wrappers/worldGeneration/WorldGenerationStep.java +++ b/common/src/main/java/com/seibel/lod/common/wrappers/worldGeneration/WorldGenerationStep.java @@ -1079,6 +1079,16 @@ public final class WorldGenerationStep { return (getBrightness(LightLayer.SKY, blockPos) >= getMaxLightLevel()); } + @Override + public ChunkAccess getChunk(int i, int j) { + return this.getChunk(i, j, ChunkStatus.EMPTY); + } + + @Override + public ChunkAccess getChunk(int i, int j, ChunkStatus chunkStatus) { + return this.getChunk(i, j, chunkStatus, true); + } + @Override @Nullable public ChunkAccess getChunk(int i, int j, ChunkStatus chunkStatus, boolean bl) { diff --git a/fabric/build.gradle b/fabric/build.gradle index 8098808e5..eb86e3880 100644 --- a/fabric/build.gradle +++ b/fabric/build.gradle @@ -60,6 +60,9 @@ dependencies { // Sodium modImplementation "maven.modrinth:sodium:${project.sodium_version}" implementation "org.joml:joml:1.10.2" + + // Lithium + modImplementation "maven.modrinth:lithium:${project.lithium_version}" // Iris // modImplementation "maven.modrinth:iris:${project.iris_version}" diff --git a/gradle.properties b/gradle.properties index d80509a79..d857a60d4 100644 --- a/gradle.properties +++ b/gradle.properties @@ -14,6 +14,7 @@ fabric_api_version=0.44.0+1.18 # Fabric mods modmenu_version=3.0.0 starlight_version_fabric=3554912 + lithium_version=mc1.18.1-0.7.7 sodium_version=mc1.18-0.4.0-alpha5 iris_version=1.18.x-v1.1.4 immersive_portals_version = v1.0.4-1.18