From 164d4071538c6681a892b5ce1fd7457c0b270975 Mon Sep 17 00:00:00 2001 From: Leonardo Date: Sat, 16 Oct 2021 15:51:35 +0200 Subject: [PATCH] Experimental light system is a config now --- .../com/seibel/lod/builders/lodBuilding/LodBuilder.java | 4 +--- src/main/java/com/seibel/lod/config/LodConfig.java | 6 ++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java b/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java index c45370b55..de0e9fa6e 100644 --- a/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java +++ b/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java @@ -85,8 +85,6 @@ public class LodBuilder /** Minecraft's max light value */ public static final short DEFAULT_MAX_LIGHT = 15; - //TODO make it config - public static final boolean USE_EXPERIMENTAL_SKYLIGHT = false; /** * How wide LodDimensions should be in regions
@@ -441,7 +439,7 @@ public class LodBuilder skyLight = DEFAULT_MAX_LIGHT; else { - if (USE_EXPERIMENTAL_SKYLIGHT) + if (LodConfig.CLIENT.worldGenerator.useExperimentalSkyLight.get()) { skyLight = world.getBrightness(LightType.SKY, blockPos); if (!chunk.isLightCorrect() && (skyLight == 0 || skyLight == 15)) diff --git a/src/main/java/com/seibel/lod/config/LodConfig.java b/src/main/java/com/seibel/lod/config/LodConfig.java index 9f24ff7b4..3db89ee07 100644 --- a/src/main/java/com/seibel/lod/config/LodConfig.java +++ b/src/main/java/com/seibel/lod/config/LodConfig.java @@ -196,6 +196,7 @@ public class LodConfig public final ForgeConfigSpec.BooleanValue allowUnstableFeatureGeneration; public final ForgeConfigSpec.EnumValue horizontalScale; public final ForgeConfigSpec.EnumValue horizontalQuality; + public final ForgeConfigSpec.BooleanValue useExperimentalSkyLight; public final ForgeConfigSpec.BooleanValue avoidBlockWithNoCollision; public final ForgeConfigSpec.BooleanValue avoidNonFullBlock; @@ -320,6 +321,11 @@ public class LodConfig + " https://gitlab.com/jeseibel/minecraft-lod-mod/-/issues/35 \n") .define("allowUnstableFeatureGeneration", false); + useExperimentalSkyLight = builder + .comment("\n\n" + + " Change how sky light value is calculated in the fake chunks \n") + .define("use experimental sky light system", false); + avoidBlockWithNoCollision = builder .comment("\n\n" + " if true avoid block that have no collision box in the generation \n"