From 11c419e5038013ffd258e77255cf17979a8c8608 Mon Sep 17 00:00:00 2001 From: cola98765 Date: Wed, 13 Oct 2021 10:15:48 +0200 Subject: [PATCH] updated some TODO's --- .../com/seibel/lod/builders/lodBuilding/LodBuilder.java | 2 +- .../lod/builders/worldGeneration/LodNodeGenWorker.java | 4 ++-- .../java/com/seibel/lod/objects/PosToRenderContainer.java | 3 ++- .../java/com/seibel/lod/objects/SingleLevelContainer.java | 7 +++++-- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java b/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java index 3f73a1908..0d301843e 100644 --- a/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java +++ b/src/main/java/com/seibel/lod/builders/lodBuilding/LodBuilder.java @@ -582,7 +582,7 @@ public class LodBuilder // add to the running averages - count = colorMultiplier + count; // TODO shouldn't colorMultiplier be multiplied by? + count += colorMultiplier; alpha += ColorUtil.getAlpha(color) * colorMultiplier; red += ColorUtil.getBlue(color) * colorMultiplier; green += ColorUtil.getGreen(color) * colorMultiplier; diff --git a/src/main/java/com/seibel/lod/builders/worldGeneration/LodNodeGenWorker.java b/src/main/java/com/seibel/lod/builders/worldGeneration/LodNodeGenWorker.java index 703a07304..47ff416b0 100644 --- a/src/main/java/com/seibel/lod/builders/worldGeneration/LodNodeGenWorker.java +++ b/src/main/java/com/seibel/lod/builders/worldGeneration/LodNodeGenWorker.java @@ -170,7 +170,7 @@ public class LodNodeGenWorker implements IWorker // only generate LodChunks if they can // be added to the current LodDimension - /* TODO i must disable this if, i will find a way to replace it */ + /* TODO I must disable this 'if', if I will find a way to replace it */ if (lodDim.regionIsInRange(pos.x / LodUtil.REGION_WIDTH_IN_CHUNKS, pos.z / LodUtil.REGION_WIDTH_IN_CHUNKS)) { // long startTime = System.currentTimeMillis(); @@ -377,7 +377,7 @@ public class LodNodeGenWorker implements IWorker lodBuilder.generateLodNodeFromChunk(lodDim, chunk, new LodBuilderConfig(DistanceGenerationMode.SURFACE)); - /**TODO if we want to use Biome utils and terrain utils for overworld + /*TODO if we want to use Biome utils and terrain utils for overworld * lodBuilder.generateLodNodeFromChunk(lodDim, pos ,detailLevel, serverWorld.getSeed());*/ } diff --git a/src/main/java/com/seibel/lod/objects/PosToRenderContainer.java b/src/main/java/com/seibel/lod/objects/PosToRenderContainer.java index e58888a80..0ec131584 100644 --- a/src/main/java/com/seibel/lod/objects/PosToRenderContainer.java +++ b/src/main/java/com/seibel/lod/objects/PosToRenderContainer.java @@ -19,7 +19,8 @@ public class PosToRenderContainer private int regionPosZ; private int numberOfPosToRender; private int[] posToRender; - /*TODO this population matrix could be converted to boolean to improve memory use*/ + /*TODO this population matrix could be converted to boolean to improve memory use + * no since bools are stored as bytes anyway - cola*/ private byte[][] population; public PosToRenderContainer(byte minDetail, int regionPosX, int regionPosZ) diff --git a/src/main/java/com/seibel/lod/objects/SingleLevelContainer.java b/src/main/java/com/seibel/lod/objects/SingleLevelContainer.java index 8ce158e1e..4da2d1b54 100644 --- a/src/main/java/com/seibel/lod/objects/SingleLevelContainer.java +++ b/src/main/java/com/seibel/lod/objects/SingleLevelContainer.java @@ -111,7 +111,9 @@ public class SingleLevelContainer implements LevelContainer { posX = LevelPosUtil.getRegionModule(detailLevel, posX); posZ = LevelPosUtil.getRegionModule(detailLevel, posZ); - // TODO Improve this using a thread map to long[] + /* TODO Improve this using a thread map to long[] + * actually single level stuff is already kinda deprecated - cola*/ + return dataContainer[posX][posZ]; } @@ -120,7 +122,8 @@ public class SingleLevelContainer implements LevelContainer { posX = LevelPosUtil.getRegionModule(detailLevel, posX); posZ = LevelPosUtil.getRegionModule(detailLevel, posZ); - // TODO Improve this using a thread map to long[] + /* TODO Improve this using a thread map to long[] + * actually single level stuff is already kinda deprecated - cola*/ return dataContainer[posX][posZ]; }