Speed up shutdown and reduce logging

core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/V2/FullDataSourceProviderV2.java

@@ -47,6 +47,7 @@ import java.io.IOException;
 import java.sql.SQLException;
 import java.util.*;
 import java.util.concurrent.*;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.locks.ReentrantLock;
 
 /**
@@ -76,14 +77,11 @@ public class FullDataSourceProviderV2 implements IDebugRenderable, AutoCloseable
 	public static final byte LEAF_SECTION_DETAIL_LEVEL = DhSectionPos.SECTION_MINIMUM_DETAIL_LEVEL;
 	
 	
-	
-	protected final ReentrantLock closeLock = new ReentrantLock();
-	protected volatile boolean isShutdown = false;
-	
-	protected final File saveDir;
-	
 	public final FullDataSourceV2Repo repo;
 	
+	
+	protected final AtomicBoolean isShutdownRef = new AtomicBoolean(false);
+	protected final File saveDir;
 	protected final IDhLevel level;
 	protected final String levelId;
 	
@@ -174,6 +172,11 @@ public class FullDataSourceProviderV2 implements IDebugRenderable, AutoCloseable
 	 */
 	public CompletableFuture<FullDataSourceV2> getAsync(long pos)
 	{
+		if (this.isShutdownRef.get())
+		{
+			return CompletableFuture.completedFuture(null);
+		}
+		
 		AbstractExecutorService executor = ThreadPoolUtil.getFileHandlerExecutor();
 		if (executor == null || executor.isTerminated())
 		{
@@ -199,6 +202,11 @@ public class FullDataSourceProviderV2 implements IDebugRenderable, AutoCloseable
 	@Nullable
 	public FullDataSourceV2 get(long pos)
 	{
+		if (this.isShutdownRef.get())
+		{
+			return null;
+		}
+		
 		try(FullDataSourceV2DTO dto = this.repo.getByKey(pos))
 		{
 			if (dto == null)
@@ -267,6 +275,11 @@ public class FullDataSourceProviderV2 implements IDebugRenderable, AutoCloseable
 	 */
 	public FullDataSourceV2 getAdjForDirection(long pos, EDhDirection direction)
 	{
+		if (this.isShutdownRef.get())
+		{
+			return null;
+		}
+		
 		try(FullDataSourceV2DTO dto = this.repo.getAdjByPosAndDirection(pos, direction))
 		{
 			if (dto == null)
@@ -386,7 +399,14 @@ public class FullDataSourceProviderV2 implements IDebugRenderable, AutoCloseable
 	
 	@Nullable
 	public Long getTimestampForPos(long pos)
-	{ return this.repo.getTimestampForPos(pos); }
+	{
+		if (this.isShutdownRef.get())
+		{
+			return null;
+		}
+		
+		return this.repo.getTimestampForPos(pos); 
+	}
 	
 	
 	
@@ -415,30 +435,17 @@ public class FullDataSourceProviderV2 implements IDebugRenderable, AutoCloseable
 	
 	@Override 
 	public void close()
-	{
-		try
 	{
 		LOGGER.debug("Closing [" + this.getClass().getSimpleName() + "] for level: [" + this.levelId + "].");
 		
-			this.closeLock.lock();
+		this.isShutdownRef.set(true);
-			this.isShutdown = true;
 		
 		this.dataUpdater.close();
 		this.updatePropagator.close();
 		this.dataMigratorV1.close();
 		
-			// wait a moment so any queued saves can finish queuing, 
-			// otherwise we might not see everything that needs saving and attempt to use a closed repo
-			Thread.sleep(200);
-			
 		this.repo.close();
 	}
-		catch (InterruptedException ignore) { }
-		finally
-		{
-			this.closeLock.unlock();
-		}
-	}
 	
 	
 	

core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/V2/FullDataUpdatePropagatorV2.java

@@ -23,6 +23,7 @@ import java.util.Set;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.RejectedExecutionException;
 import java.util.concurrent.ThreadPoolExecutor;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.locks.ReentrantLock;
 
 public class FullDataUpdatePropagatorV2 implements IDebugRenderable, AutoCloseable
@@ -41,9 +42,6 @@ public class FullDataUpdatePropagatorV2 implements IDebugRenderable, AutoCloseab
 	{ return NUMBER_OF_PARENT_UPDATE_TASKS_PER_THREAD * Config.Common.MultiThreading.numberOfThreads.get(); }
 	
 	
-	private final FullDataSourceProviderV2 provider;
-	private final FullDataUpdaterV2 dataUpdater;
-	
 	
 	/**
 	 * Tracks which positions are currently being updated
@@ -59,9 +57,14 @@ public class FullDataUpdatePropagatorV2 implements IDebugRenderable, AutoCloseab
 	@Nullable
 	public final ThreadPoolExecutor updateQueueProcessor;
 	
+	private final AtomicBoolean isShutdownRef = new AtomicBoolean(false);
 	private final String levelId;
 	
 	
+	private final FullDataSourceProviderV2 provider;
+	private final FullDataUpdaterV2 dataUpdater;
+	
+	
 	
 	//=============//
 	// constructor //
@@ -125,8 +128,6 @@ public class FullDataUpdatePropagatorV2 implements IDebugRenderable, AutoCloseab
 				LOGGER.error("Unexpected error in the parent update queue thread. Error: " + e.getMessage(), e);
 			}
 		}
-		
-		LOGGER.info("Update thread ["+Thread.currentThread().getName()+"] terminated.");
 	}
 	/** will always apply updates */
 	private void runParentUpdates(PriorityTaskPicker.Executor executor, DhBlockPos targetBlockPos)
@@ -387,20 +388,10 @@ public class FullDataUpdatePropagatorV2 implements IDebugRenderable, AutoCloseab
 	@Override
 	public void close()
 	{
-		try
-		{
-			//LOGGER.info("Closing [" + this.getClass().getSimpleName() + "] for level: [" + this.levelId + "].");
-			
 		if (this.updateQueueProcessor != null)
 		{
 			this.updateQueueProcessor.shutdownNow();
 		}
-			
-			// wait a moment so any queued saves can finish queuing, 
-			// otherwise we might not see everything that needs saving and attempt to use a closed repo
-			Thread.sleep(200);
-		}
-		catch (InterruptedException ignore) { }
 	}
 	
 	

core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/V2/FullDataUpdaterV2.java

@@ -19,6 +19,7 @@ import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Set;
 import java.util.concurrent.*;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.locks.ReentrantLock;
 
@@ -26,10 +27,6 @@ public class FullDataUpdaterV2 implements IDebugRenderable, AutoCloseable
 {
 	private static final DhLogger LOGGER = new DhLoggerBuilder().build();
 	
-	
-	private final FullDataSourceProviderV2 provider;
-	
-	
 	protected final PositionalLockProvider updateLockProvider = new PositionalLockProvider();
 	/**
 	 * generally just used for debugging,
@@ -41,6 +38,9 @@ public class FullDataUpdaterV2 implements IDebugRenderable, AutoCloseable
 	public final ArrayList<IDataSourceUpdateListenerFunc<FullDataSourceV2>> dateSourceUpdateListeners = new ArrayList<>();
 	
 	private final String levelId;
+	private final AtomicBoolean isShutdownRef = new AtomicBoolean(false);
+	
+	private final FullDataSourceProviderV2 provider;
 	
 	
 	
@@ -67,6 +67,11 @@ public class FullDataUpdaterV2 implements IDebugRenderable, AutoCloseable
 	 */
 	public CompletableFuture<Void> updateDataSourceAsync(@NotNull FullDataSourceV2 inputDataSource)
 	{
+		if (this.isShutdownRef.get())
+		{
+			return CompletableFuture.completedFuture(null);
+		}
+		
 		AbstractExecutorService executor = ThreadPoolUtil.getChunkToLodBuilderExecutor();
 		if (executor == null || executor.isTerminated())
 		{
@@ -104,6 +109,12 @@ public class FullDataUpdaterV2 implements IDebugRenderable, AutoCloseable
 	/** After this method returns the inputData will be written to file. */
 	public void updateDataSource(@NotNull FullDataSourceV2 inputData, boolean lockOnUpdatePos)
 	{
+		if (this.isShutdownRef.get())
+		{
+			return;
+		}
+		
+		
 		long updatePos = inputData.getPos();
 		
 		boolean methodLocked = false;
@@ -231,7 +242,7 @@ public class FullDataUpdaterV2 implements IDebugRenderable, AutoCloseable
 	@Override
 	public void close()
 	{
-		//LOGGER.info("Closing [" + this.getClass().getSimpleName() + "] for level: [" + this.levelId + "].");
+		this.isShutdownRef.set(true);
 	}
 	
 	

core/src/main/java/com/seibel/distanthorizons/core/generation/WorldGenerationQueue.java

@@ -621,19 +621,13 @@ public class WorldGenerationQueue implements IFullDataSourceRetrievalQueue, IDeb
 		LodUtil.assertTrue(this.generatorClosingFuture != null);
 		
 		
-		LOGGER.info("Awaiting world generator thread pool termination...");
+		LOGGER.info("Shutting down world generator thread pool...");
-		try
+		
-		{
-			int waitTimeInSeconds = 3;
 		AbstractExecutorService executor = ThreadPoolUtil.getWorldGenExecutor();
-			if (executor != null && !executor.awaitTermination(waitTimeInSeconds, TimeUnit.SECONDS))
+		if (executor != null)
 		{
-				LOGGER.warn("World generator thread pool shutdown didn't complete after [" + waitTimeInSeconds + "] seconds. Some world generator requests may still be running.");
+			List<Runnable> tasks = executor.shutdownNow();
-			}
+			LOGGER.info("World generator thread pool shutdown with [" + tasks.size() + "] incomplete tasks.");
-		}
-		catch (InterruptedException e)
-		{
-			LOGGER.warn("World generator thread pool shutdown interrupted! Ignoring child threads...", e);
 		}
 		
 		

core/src/main/java/com/seibel/distanthorizons/core/level/DhServerLevel.java

@@ -107,7 +107,6 @@ public class DhServerLevel extends AbstractDhServerLevel
 	{
 		super.close();
 		this.serverside.close();
-		LOGGER.info("Closed DHLevel for ["+this.getLevelWrapper()+"].");
 	}
 	
 }

core/src/main/java/com/seibel/distanthorizons/core/sql/repo/AbstractDhRepo.java

@@ -369,7 +369,7 @@ public abstract class AbstractDhRepo<TKey, TDTO extends IBaseDTO<TKey>> implemen
 			
 			if (DbConnectionClosedException.isClosedException(e))
 			{
-				throw new DbConnectionClosedException(e);
+				return new ArrayList<>();
 			}
 			else
 			{

core/src/main/java/com/seibel/distanthorizons/core/util/threading/PriorityTaskPicker.java

@@ -98,10 +98,6 @@ public class PriorityTaskPicker
 							// Clear this executor's tasks since we no longer expect anything to execute.
 							executor.taskQueue.clear();
 						}
-						else
-						{
-							throw e;
-						}
 					}
 				}
 			}

core/src/main/java/com/seibel/distanthorizons/core/world/AbstractDhServerWorld.java

@@ -10,8 +10,10 @@ import com.seibel.distanthorizons.core.wrapperInterfaces.world.ILevelWrapper;
 import com.seibel.distanthorizons.core.wrapperInterfaces.world.IServerLevelWrapper;
 import org.jetbrains.annotations.NotNull;
 
+import java.util.ArrayList;
 import java.util.HashSet;
 import java.util.Iterator;
+import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentHashMap;
 
 public abstract class AbstractDhServerWorld<TDhServerLevel extends AbstractDhServerLevel> extends AbstractDhWorld implements IDhServerWorld
@@ -134,10 +136,9 @@ public abstract class AbstractDhServerWorld<TDhServerLevel extends AbstractDhSer
 	@Override
 	public void close()
 	{
+		ArrayList<CompletableFuture<Void>> closeFutures = new ArrayList<>();
 		for (TDhServerLevel level : this.dhLevelByLevelWrapper.values())
 		{
-			LOGGER.info("Unloading level [" + level.getLevelWrapper().getDhIdentifier() + "].");
-			
 			// level wrapper shouldn't be null, but just in case
 			IServerLevelWrapper serverLevelWrapper = level.getServerLevelWrapper();
 			if (serverLevelWrapper != null)
@@ -145,7 +146,23 @@ public abstract class AbstractDhServerWorld<TDhServerLevel extends AbstractDhSer
 				serverLevelWrapper.onUnload();
 			}
 			
+			
+			// close levels asynchronously to speed up
+			// shutdown on servers with a lot of levels
+			CompletableFuture<Void> closeFuture = new CompletableFuture<>();
+			Thread closeThread = new Thread(() ->
+			{
 				level.close();
+				closeFuture.complete(null);
+			}, "level shutdown");
+			closeThread.start();
+			closeFutures.add(closeFuture);
+		}
+		
+		// wait for all the levels to finish closing
+		for (CompletableFuture<Void> future : closeFutures)
+		{
+			future.join();
 		}
 		
 		this.dhLevelByLevelWrapper.clear();

core/src/main/java/com/seibel/distanthorizons/core/world/DhClientServerWorld.java

@@ -28,9 +28,11 @@ import com.seibel.distanthorizons.core.wrapperInterfaces.world.ILevelWrapper;
 import com.seibel.distanthorizons.core.wrapperInterfaces.world.IServerLevelWrapper;
 import org.jetbrains.annotations.NotNull;
 
+import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.Set;
+import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutorService;
 
 public class DhClientServerWorld extends AbstractDhServerWorld<DhClientServerLevel> implements IDhClientWorld
@@ -143,13 +145,13 @@ public class DhClientServerWorld extends AbstractDhServerWorld<DhClientServerLev
 	@Override
 	public synchronized void close()
 	{
+		ArrayList<CompletableFuture<Void>> closeFutures = new ArrayList<>();
+		
 		synchronized (this.dhLevels)
 		{
 			// close each level
 			for (DhClientServerLevel level : this.dhLevels)
 			{
-				LOGGER.info("Unloading level [" + level.getServerLevelWrapper().getDhIdentifier() + "].");
-				
 				// level wrapper shouldn't be null, but just in case
 				IServerLevelWrapper serverLevelWrapper = level.getServerLevelWrapper();
 				if (serverLevelWrapper != null)
@@ -157,10 +159,26 @@ public class DhClientServerWorld extends AbstractDhServerWorld<DhClientServerLev
 					serverLevelWrapper.onUnload();
 				}
 				
+				// close levels asynchronously to speed up
+				// shutdown on servers with a lot of levels
+				CompletableFuture<Void> closeFuture = new CompletableFuture<>();
+				Thread closeThread = new Thread(() -> 
+				{
 					level.close();
+					closeFuture.complete(null);
+				}, "level shutdown");
+				closeThread.start();
+				closeFutures.add(closeFuture);
 			}
 		}
 		
+		// wait for all the levels to finish closing
+		for (CompletableFuture<Void> future : closeFutures)
+		{
+			future.join();
+		}
+		
+		
 		this.dhLevelByLevelWrapper.clear();
 		this.eventLoop.close();
 		LOGGER.info("Closed DhWorld of type " + this.environment);

core/src/main/java/com/seibel/distanthorizons/core/world/DhClientWorld.java

@@ -29,7 +29,9 @@ import com.seibel.distanthorizons.core.wrapperInterfaces.world.IClientLevelWrapp
 import com.seibel.distanthorizons.core.wrapperInterfaces.world.ILevelWrapper;
 import org.jetbrains.annotations.NotNull;
 
+import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ExecutorService;
 
@@ -127,14 +129,11 @@ public class DhClientWorld extends AbstractDhWorld implements IDhClientWorld
 	public void close()
 	{
 		this.networkState.close();
-		
 		this.dhTickerThread.shutdownNow();
 		
-		
+		ArrayList<CompletableFuture<Void>> closeFutures = new ArrayList<>();
 		for (DhClientLevel dhClientLevel : this.levels.values())
 		{
-			LOGGER.info("Unloading level [" + dhClientLevel.getLevelWrapper().getDhIdentifier() + "].");
-			
 			// level wrapper shouldn't be null, but just in case
 			IClientLevelWrapper clientLevelWrapper = dhClientLevel.getClientLevelWrapper();
 			if (clientLevelWrapper != null)
@@ -142,7 +141,23 @@ public class DhClientWorld extends AbstractDhWorld implements IDhClientWorld
 				clientLevelWrapper.onUnload();
 			}
 			
+			
+			// close levels asynchronously to speed up
+			// shutdown on servers with a lot of levels
+			CompletableFuture<Void> closeFuture = new CompletableFuture<>();
+			Thread closeThread = new Thread(() ->
+			{
 				dhClientLevel.close();
+				closeFuture.complete(null);
+			}, "level shutdown");
+			closeThread.start();
+			closeFutures.add(closeFuture);
+		}
+		
+		// wait for all the levels to finish closing
+		for (CompletableFuture<Void> future : closeFutures)
+		{
+			future.join();
 		}
 		
 		this.levels.clear();

core/src/main/java/com/seibel/distanthorizons/core/world/DhServerWorld.java

@@ -64,7 +64,7 @@ public class DhServerWorld extends AbstractDhServerWorld<DhServerLevel>
 		
 		if (this.dhLevelByLevelWrapper.containsKey(wrapper))
 		{
-			LOGGER.info("Unloading level {} ", this.dhLevelByLevelWrapper.get(wrapper));
+			DhServerLevel level = this.dhLevelByLevelWrapper.get(wrapper);
 			wrapper.onUnload();
 			this.dhLevelByLevelWrapper.remove(wrapper).close();
 		}