From 9d539c476622baeeb13d2c0a53052b9f1e171885 Mon Sep 17 00:00:00 2001 From: James Seibel Date: Sun, 17 Mar 2024 16:15:06 -0500 Subject: [PATCH] Update several todo comments --- .../core/dataObjects/fullData/FullDataPointIdMap.java | 1 + .../core/file/AbstractNewDataSourceHandler.java | 2 +- .../core/file/fullDatafile/FullDataFileHandlerV2.java | 3 ++- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java b/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java index 4df982758..468d57bee 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java @@ -44,6 +44,7 @@ import java.util.concurrent.locks.ReentrantReadWriteLock; * since it stringifies every block and biome name, which is quite bulky. * It might be worth while to have a biome and block ID that then both get mapped * to the data point ID to reduce file size. + * And/or it would be good to dynamically remove IDs that aren't currently in use. * * @author Leetom */ diff --git a/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java b/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java index bfe9cabfc..7648f16de 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java @@ -35,7 +35,7 @@ public abstract class AbstractNewDataSourceHandler * * @see AbstractNewDataSourceHandler#MIN_SECTION_DETAIL_LEVEL */ - public static final byte TOP_SECTION_DETAIL_LEVEL = DhSectionPos.SECTION_MINIMUM_DETAIL_LEVEL + LodUtil.REGION_DETAIL_LEVEL; // TODO add "section" to detail level + public static final byte TOP_SECTION_DETAIL_LEVEL = DhSectionPos.SECTION_MINIMUM_DETAIL_LEVEL + LodUtil.REGION_DETAIL_LEVEL; /** * The lowest numerical detail level possible. * diff --git a/core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/FullDataFileHandlerV2.java b/core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/FullDataFileHandlerV2.java index ead649c20..2c28070de 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/FullDataFileHandlerV2.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/file/fullDatafile/FullDataFileHandlerV2.java @@ -156,7 +156,8 @@ public class FullDataFileHandlerV2 @Override protected FullDataSourceV2 createNewDataSourceFromExistingDtos(DhSectionPos pos) { - // TODO maybe just set children update flags to true? + // TODO maybe just set children update flags to true? + // TODO is any special logic necessary? All DTOs should be generated using their children via the update system anyway return FullDataSourceV2.createEmpty(pos); }