wisplite/distant-horizons-core-sharded
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce rare generic object VBO upload race condition

Browse Source
This commit is contained in:
James Seibel
2026-06-01 21:44:59 -05:00
parent 299ab0f856
commit 9754943752
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/com/seibel/distanthorizons/core/render/renderer/RenderableBoxGroup.java
+8 -6
View File
@@ -205,21 +205,20 @@ public class RenderableBoxGroup
this.vertexBufferContainer = this.altVertexBufferContainer; this.vertexBufferContainer = this.altVertexBufferContainer;
this.altVertexBufferContainer = temp; this.altVertexBufferContainer = temp;
this.vertexDataDirty = false;
return; return;
} }
// if the vertex data is already up to date, do nothing // executor should always be available, if not that probably means the level is being shut down
if (!this.vertexDataDirty) PriorityTaskPicker.Executor executor = ThreadPoolUtil.getRenderLoadingExecutor();
if (executor == null || executor.isTerminated())
{ {
return; return;
} }
PriorityTaskPicker.Executor executor = ThreadPoolUtil.getRenderLoadingExecutor(); // if the vertex data is already up to date, do nothing
if (executor == null || executor.isTerminated()) if (!this.vertexDataDirty)
{ {
return; return;
} }
@@ -250,6 +249,9 @@ public class RenderableBoxGroup
{ {
this.altVertexBufferContainer.updateVertexData(this.uploadBoxList); this.altVertexBufferContainer.updateVertexData(this.uploadBoxList);
this.altVertexBufferContainer.setState(IDhGenericObjectVertexBufferContainer.EState.READY_TO_UPLOAD); this.altVertexBufferContainer.setState(IDhGenericObjectVertexBufferContainer.EState.READY_TO_UPLOAD);
// upload complete
this.vertexDataDirty = false;
} }
catch (Exception e) catch (Exception e)
{ {