From 8bd70d593ccbf6f7d6deea4df956e5c19c0bb7bd Mon Sep 17 00:00:00 2001 From: James Seibel Date: Sun, 30 Mar 2025 14:36:51 -0500 Subject: [PATCH] Fix flashing on MC 1.21.5 in non-overworld dimensions --- .../distanthorizons/core/render/RenderBufferHandler.java | 1 + .../distanthorizons/core/render/renderer/LodRenderer.java | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/core/src/main/java/com/seibel/distanthorizons/core/render/RenderBufferHandler.java b/core/src/main/java/com/seibel/distanthorizons/core/render/RenderBufferHandler.java index 89534a5ce..5ef07259e 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/render/RenderBufferHandler.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/render/RenderBufferHandler.java @@ -359,6 +359,7 @@ public class RenderBufferHandler implements AutoCloseable // debug wireframe setup // //=======================// + // TODO move this logic into LodRenderer so all the GL states can be handled there boolean renderWireframe = Config.Client.Advanced.Debugging.renderWireframe.get(); if (renderWireframe) { diff --git a/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/LodRenderer.java b/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/LodRenderer.java index a25dcdf22..a688d7664 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/LodRenderer.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/LodRenderer.java @@ -571,6 +571,10 @@ public class LodRenderer GLMC.glDepthFunc(GL32.GL_LESS); GLMC.enableDepthMask(); + // This is required for MC versions 1.21.5+ + // due to MC updating the lightmap by changing the viewport size + GL32.glViewport(0, 0, this.cachedWidth, this.cachedHeight); + /*---------Bind required objects--------*/ // Setup LodRenderProgram and the LightmapTexture if it has not yet been done // also binds LightmapTexture, VAO, and ShaderProgram