Add a bunch of TODO comments

This commit is contained in:
James Seibel
2026-01-26 06:50:55 -06:00
parent 4346a2e803
commit 87bfbf1afe
8 changed files with 13 additions and 7 deletions
@@ -61,7 +61,7 @@ public class DhApiGraphicsConfig implements IDhApiGraphicsConfig
@Override
public IDhApiConfigValue<Boolean> renderingEnabled()
{ return new DhApiConfigValue<EDhApiRendererMode, Boolean>(Config.Client.Advanced.Debugging.rendererMode, new RenderModeEnabledConverter()); }
{ return new DhApiConfigValue<EDhApiRendererMode, Boolean>(Config.Client.Advanced.Debugging.rendererMode, new RenderModeEnabledConverter()); } // TODO fix getApiValue not returning null if unset
@Override
public IDhApiConfigValue<EDhApiRendererMode> renderingMode()
@@ -631,7 +631,7 @@ public class ClientApi
* The first fade pass.
* Called after MC finishes rendering the opaque passes.
*/
public void renderFadeOpaque()
public void renderFadeOpaque() // TODO is this actually the transparent pass in MC 1.21.11?
{
// only fade when DH is rendering
if (Config.Client.Advanced.Debugging.rendererMode.get() == EDhApiRendererMode.DEFAULT
@@ -653,7 +653,7 @@ public class ClientApi
* Called after MC finishes rendering both opaque
* and transparent passes.
*/
public void renderFadeTransparent()
public void renderFadeTransparent() // TODO is this actually the opaque pass in MC 1.21.11?
{
// only fade when DH is rendering
if (Config.Client.Advanced.Debugging.rendererMode.get() == EDhApiRendererMode.DEFAULT)
@@ -43,7 +43,7 @@ public class ConfigEntry<T> extends AbstractConfigBase<T>
private final String comment;
private T min;
private T max;
private final ArrayList<IConfigListener> listenerList;
private final ArrayList<IConfigListener> listenerList; // TODO make concurrent
private final String chatCommandName;
/**
@@ -67,9 +67,13 @@ public final class BufferQuad
EDhDirection direction)
{
if (widthEastWest == 0 || widthNorthSouthOrUpDown == 0)
{
throw new IllegalArgumentException("Size 0 quad!");
}
if (widthEastWest < 0 || widthNorthSouthOrUpDown < 0)
{
throw new IllegalArgumentException("Negative sized quad!");
}
this.x = x;
this.y = y;
@@ -138,7 +138,7 @@ public abstract class AbstractDhLevel implements IDhLevel
{
// only add clouds for certain dimension types
if (!this.getLevelWrapper().hasCeiling()
&& !this.getLevelWrapper().getDimensionType().isTheEnd())
&& !this.getLevelWrapper().getDimensionType().isTheEnd()) // TODO config value for white/black list
{
this.cloudRenderHandler = new CloudRenderHandler((IDhClientLevel)this, genericRenderer);
}
@@ -298,7 +298,7 @@ public class LodRequestModule implements Closeable
remainingChunkCount += this.retrievalQueue.getQueuedChunkCount();
String remainingChunkCountStr = F3Screen.NUMBER_FORMAT.format(remainingChunkCount);
String message = "DH is generating chunks. " + remainingChunkCountStr + " left.";
String message = "DH is generating chunks. " + remainingChunkCountStr + " left."; // TODO getting stuck at 32 chunks remaining
// show a message about how to disable progress logging if requested
int msToShowDisableInstructions = Config.Common.WorldGenerator.generationProgressDisableMessageDisplayTimeInSeconds.get() * 1_000;
@@ -364,7 +364,7 @@ public class CloudRenderHandler
// if debug colors are enabled don't change them
if (!DEBUG_BORDER_COLORS
// don't modify cloud groups that aren't active
&& boxGroup.isActive())
&& boxGroup.isActive()) // TODO bake generic objects for clouds
{
// cloud color changes based on the time of day and weather so we need to get it from the level
Color newCloudColor = this.level.getClientLevelWrapper().getCloudColor(renderParam.partialTicks);
@@ -179,9 +179,11 @@ float exponentialSquaredFog(
//
// generated methods //
//
// TODO cleanup comment regions
float getFarFogThickness(float dist)
{
// TODO these uniforms aren't being set
if (uFogFalloffType == 0) // LINEAR
{
return linearFog(dist, uFarFogStart, uFarFogLength, uFarFogMin, uFarFogRange);