From 7d84e05b1f18240df8dab79002d6d8103b5054a6 Mon Sep 17 00:00:00 2001 From: James Seibel Date: Sat, 9 Sep 2023 18:26:00 -0500 Subject: [PATCH] Move framebuffer unbinding to GLState --- .../seibel/distanthorizons/core/render/glObject/GLState.java | 3 +++ .../core/render/renderer/shaders/AbstractShaderRenderer.java | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/com/seibel/distanthorizons/core/render/glObject/GLState.java b/core/src/main/java/com/seibel/distanthorizons/core/render/glObject/GLState.java index d6f8cb4c0..216a2067f 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/render/glObject/GLState.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/render/glObject/GLState.java @@ -120,6 +120,9 @@ public class GLState public void RestoreFrameBuffer() { + // explicitly unbinding the frame buffer is necessary to prevent GL_CLEAR calls from hitting the wrong buffer + GL32.glBindFramebuffer(GL32.GL_FRAMEBUFFER, 0); + for (int i = 0; i < FBO_MAX; i++) { int buffer = this.fbo[i]; diff --git a/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/shaders/AbstractShaderRenderer.java b/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/shaders/AbstractShaderRenderer.java index 4eae2f43e..9dc1006a5 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/shaders/AbstractShaderRenderer.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/render/renderer/shaders/AbstractShaderRenderer.java @@ -116,9 +116,6 @@ public abstract class AbstractShaderRenderer GL32.glBlendFunc(GL32.GL_SRC_ALPHA, GL32.GL_ONE_MINUS_SRC_ALPHA); GL32.glDrawArrays(GL32.GL_TRIANGLES, 0, 6); - // explicitly unbinding the frame buffer is necessary to prevent GL_CLEAR calls from hitting the wrong buffer - GL32.glBindFramebuffer(GL32.GL_FRAMEBUFFER, 0); - state.restore(); }