From 64fe804c4048f1166ee86e7739710acf48273462 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Vojt=C4=9Bch=20=C5=A0okala?= Date: Sat, 16 May 2026 13:33:42 +0200 Subject: [PATCH] Make renderingString show correct value if rendering is disabled for this dimension --- .../seibel/distanthorizons/core/level/DhClientLevel.java | 6 ++++-- .../distanthorizons/core/level/DhClientServerLevel.java | 6 ++++-- .../main/resources/assets/distanthorizons/lang/en_us.json | 2 +- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientLevel.java b/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientLevel.java index 4246b86dd..4c63caac6 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientLevel.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientLevel.java @@ -21,6 +21,7 @@ package com.seibel.distanthorizons.core.level; import com.google.common.cache.CacheBuilder; import com.seibel.distanthorizons.core.config.Config; +import com.seibel.distanthorizons.core.config.eventHandlers.IgnoredDimensionCsvHandler; import com.seibel.distanthorizons.core.dataObjects.fullData.sources.FullDataSourceV2; import com.seibel.distanthorizons.core.dependencyInjection.SingletonInjector; import com.seibel.distanthorizons.core.enums.MinecraftTextFormat; @@ -333,12 +334,13 @@ public class DhClientLevel extends AbstractDhLevel implements IDhClientLevel String o = MinecraftTextFormat.ORANGE; String y = MinecraftTextFormat.YELLOW; String g = MinecraftTextFormat.GREEN; + String r = MinecraftTextFormat.RED; String cf = MinecraftTextFormat.CLEAR_FORMATTING; String dimName = this.levelWrapper.getDhIdentifier(); - boolean rendering = this.clientside.isRendering(); - String renderingString = rendering ? (g+"yes"+cf) : (o+"no"+cf); + boolean rendering = this.clientside.isRendering() && !IgnoredDimensionCsvHandler.INSTANCE.dimensionNameShouldBeIgnored(dimName); + String renderingString = rendering ? (g+"yes"+cf) : (r+"no"+cf); messageList.add("["+y+dimName+cf+"] rendering: "+renderingString); diff --git a/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientServerLevel.java b/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientServerLevel.java index 5dfb921ea..ac277d867 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientServerLevel.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/level/DhClientServerLevel.java @@ -19,6 +19,7 @@ package com.seibel.distanthorizons.core.level; +import com.seibel.distanthorizons.core.config.eventHandlers.IgnoredDimensionCsvHandler; import com.seibel.distanthorizons.core.dependencyInjection.SingletonInjector; import com.seibel.distanthorizons.core.enums.MinecraftTextFormat; import com.seibel.distanthorizons.core.file.structure.ISaveStructure; @@ -121,12 +122,13 @@ public class DhClientServerLevel extends AbstractDhServerLevel implements IDhCli String o = MinecraftTextFormat.ORANGE; String y = MinecraftTextFormat.YELLOW; String g = MinecraftTextFormat.GREEN; + String r = MinecraftTextFormat.RED; String cf = MinecraftTextFormat.CLEAR_FORMATTING; String dimName = this.serverLevelWrapper.getDhIdentifier(); - boolean rendering = this.clientside.isRendering(); - String renderingString = rendering ? (g+"yes"+cf) : (o+"no"+cf); + boolean rendering = this.clientside.isRendering() && !IgnoredDimensionCsvHandler.INSTANCE.dimensionNameShouldBeIgnored(dimName); + String renderingString = rendering ? (g+"yes"+cf) : (r+"no"+cf); messageList.add("["+y+dimName+cf+"] rendering: "+renderingString); super.addDebugMenuStringsToList(messageList); diff --git a/core/src/main/resources/assets/distanthorizons/lang/en_us.json b/core/src/main/resources/assets/distanthorizons/lang/en_us.json index f5ec62ca3..17450f6c9 100644 --- a/core/src/main/resources/assets/distanthorizons/lang/en_us.json +++ b/core/src/main/resources/assets/distanthorizons/lang/en_us.json @@ -394,7 +394,7 @@ "distanthorizons.config.client.advanced.graphics.experimental.ignoredDimensionCsv": "Ignored Dimension CSV", "distanthorizons.config.client.advanced.graphics.experimental.ignoredDimensionCsv.@tooltip": - "A comma separated list of dimension resource locations where DH won't render. Example: \"minecraft:the_nether,minecraft:the_end\" \n\nNote: \nSome DH settings will be disabled and/or changed to improve \nvisuals when DH rendering is disabled.", + "A comma separated list of dimension resource locations where DH won't render. Example: \"minecraft:the_nether,minecraft:the_end\" \n\nFor Minecraft 1.12.2 and older:\nOpen the F3 screen and copy the dimension name shown in yellow.\n\nNote: \nSome DH settings will be disabled and/or changed to improve \nvisuals when DH rendering is disabled.", "distanthorizons.config.client.advanced.graphics.experimental.renderingApi": "Rendering API", "distanthorizons.config.client.advanced.graphics.experimental.renderingApi.@tooltip":