From 57bbb12b39d6d7272d36992ea968d57271cae301 Mon Sep 17 00:00:00 2001 From: James Seibel Date: Tue, 16 Sep 2025 07:44:18 -0500 Subject: [PATCH] Fix "CUSTOM" quality preset when Iris is present --- .../coreapi/interfaces/config/IConfigEntry.java | 1 + .../core/config/ConfigEntryWithPresetOptions.java | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/api/src/main/java/com/seibel/distanthorizons/coreapi/interfaces/config/IConfigEntry.java b/api/src/main/java/com/seibel/distanthorizons/coreapi/interfaces/config/IConfigEntry.java index e5d17238a..a5e4d76bc 100644 --- a/api/src/main/java/com/seibel/distanthorizons/coreapi/interfaces/config/IConfigEntry.java +++ b/api/src/main/java/com/seibel/distanthorizons/coreapi/interfaces/config/IConfigEntry.java @@ -42,6 +42,7 @@ public interface IConfigEntry void set(T newValue); T get(); + /** gets the option ignoring what the API has overridden */ T getTrueValue(); /** Sets the value without saving */ diff --git a/core/src/main/java/com/seibel/distanthorizons/core/config/ConfigEntryWithPresetOptions.java b/core/src/main/java/com/seibel/distanthorizons/core/config/ConfigEntryWithPresetOptions.java index 32a3234a9..dcf639db9 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/config/ConfigEntryWithPresetOptions.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/config/ConfigEntryWithPresetOptions.java @@ -48,7 +48,9 @@ public class ConfigEntryWithPresetOptions public HashSet getPossibleQualitiesFromCurrentOptionValue() { - TConfig inputOptionValue = this.configEntry.get(); + // get true value so we can ignore API overrides, + // users find this confusing if their preset is set to "CUSTOM" + TConfig inputOptionValue = this.configEntry.getTrueValue(); HashSet possibleQualities = new HashSet<>(); for (TQuickEnum key : this.configOptionByQualityOption.keySet())