From 43b421042d1fd03790e56a0d0eda8ef2c01aee86 Mon Sep 17 00:00:00 2001 From: s809 <43530948+s809@users.noreply.github.com> Date: Thu, 11 Jul 2024 22:08:10 +0500 Subject: [PATCH] Add a comment to semaphores --- .../com/seibel/distanthorizons/core/level/DhServerLevel.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/java/com/seibel/distanthorizons/core/level/DhServerLevel.java b/core/src/main/java/com/seibel/distanthorizons/core/level/DhServerLevel.java index 17420178c..155add792 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/level/DhServerLevel.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/level/DhServerLevel.java @@ -446,6 +446,7 @@ public class DhServerLevel extends AbstractDhLevel implements IDhServerLevel public FullDataSourceV2 fullDataSource; // Maybe there's a better way to do synchronization, but this should suffice + // Why not something like ReentrantReadWriteLock: locks should not be bound to threads public final Semaphore requestAddSemaphore = new Semaphore(Short.MAX_VALUE, true); public final Semaphore requestRemoveSemaphore = new Semaphore(Short.MAX_VALUE, true); }