diff --git a/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java b/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java index a0d391554..4df982758 100644 --- a/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java +++ b/core/src/main/java/com/seibel/distanthorizons/core/dataObjects/fullData/FullDataPointIdMap.java @@ -36,10 +36,15 @@ import java.util.HashMap; import java.util.concurrent.locks.ReentrantReadWriteLock; /** - * WARNING: This is not THREAD-SAFE! - *
- * Used to map a numerical IDs to a Biome/BlockState pair.
- *
+ * WARNING: This is not THREAD-SAFE!
+ *
+ * Used to map a numerical IDs to a Biome/BlockState pair.
+ *
+ * TODO the serializing of this map might be really big
+ * since it stringifies every block and biome name, which is quite bulky.
+ * It might be worth while to have a biome and block ID that then both get mapped
+ * to the data point ID to reduce file size.
+ *
* @author Leetom
*/
public class FullDataPointIdMap
diff --git a/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java b/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java
index c91c4319d..ac003e9f4 100644
--- a/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java
+++ b/core/src/main/java/com/seibel/distanthorizons/core/file/AbstractNewDataSourceHandler.java
@@ -181,7 +181,6 @@ public abstract class AbstractNewDataSourceHandler
return CompletableFuture.runAsync(() ->
{
this.updateDataSourceAtPos(inputDataSource.getSectionPos(), inputDataSource, true);
-
}, executor);
}
catch (RejectedExecutionException ignore)
diff --git a/core/src/main/java/com/seibel/distanthorizons/core/pos/DhLodPos.java b/core/src/main/java/com/seibel/distanthorizons/core/pos/DhLodPos.java
index b2f3cb1f4..1706e9365 100644
--- a/core/src/main/java/com/seibel/distanthorizons/core/pos/DhLodPos.java
+++ b/core/src/main/java/com/seibel/distanthorizons/core/pos/DhLodPos.java
@@ -31,6 +31,11 @@ import java.util.Objects;
*
* @author Leetom
* @version 2022-11-6
+ *
+ * @deprecated TODO replace entirely with DhSectionPos,
+ * we don't need to have a full fledged position object for
+ * positions inside a LOD, we only need this position object
+ * to get to/from the LOD section.
*/
@Deprecated
public class DhLodPos implements Comparable