From 808a80d9f4377c4c283a83fda1ef9de25c133b42 Mon Sep 17 00:00:00 2001
From: techno-sam <77073745+techno-sam@users.noreply.github.com>
Date: Fri, 17 Apr 2026 00:03:13 +0200
Subject: [PATCH] Multiloader VII

cleanup registration api
---
 .../registration/RegistrationListeners.java       |  4 ++--
 .../registration/holder/BlockHolder.java          |  2 +-
 .../registration/holder/ItemHolder.java           |  5 -----
 .../registration/holder/ItemLikeHolder.java       | 15 +++------------
 4 files changed, 6 insertions(+), 20 deletions(-)

diff --git a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/RegistrationListeners.java b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/RegistrationListeners.java
index ffd72b0..8e238af 100644
--- a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/RegistrationListeners.java
+++ b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/RegistrationListeners.java
@@ -8,7 +8,7 @@ public class RegistrationListeners<T> {
 	private @Nullable T obj;
 	private @Nullable Consumer<T> cons;
 
-	public void registered(T obj) {
+	public synchronized void registered(T obj) {
 		this.obj = obj;
 		if (cons != null) {
 			cons.accept(obj);
@@ -16,7 +16,7 @@ public class RegistrationListeners<T> {
 		}
 	}
 
-	public void addListener(Consumer<? super T> consumer) {
+	public synchronized void addListener(Consumer<? super T> consumer) {
 		if (obj != null) {
 			consumer.accept(obj);
 		} else if (cons == null) {
diff --git a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/BlockHolder.java b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/BlockHolder.java
index d7c1b17..a3ce796 100644
--- a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/BlockHolder.java
+++ b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/BlockHolder.java
@@ -5,7 +5,7 @@ import net.minecraft.resources.ResourceKey;
 import net.minecraft.world.level.block.Block;
 import net.minecraft.world.level.block.state.BlockState;
 
-public class BlockHolder<T extends Block> extends ItemLikeHolder.NonItem<T> {
+public class BlockHolder<T extends Block> extends ItemLikeHolder<T> {
 	public BlockHolder(HolderOwner<T> owner, ResourceKey<T> key) {
 		super(owner, key);
 	}
diff --git a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemHolder.java b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemHolder.java
index ecc9552..12c7c96 100644
--- a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemHolder.java
+++ b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemHolder.java
@@ -8,9 +8,4 @@ public class ItemHolder<T extends Item> extends ItemLikeHolder<T> {
 	public ItemHolder(HolderOwner<T> owner, ResourceKey<T> key) {
 		super(owner, key);
 	}
-
-	@Override
-	public boolean is(Item item) {
-		return asItem() == item;
-	}
 }
diff --git a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemLikeHolder.java b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemLikeHolder.java
index 208fc23..b6acd94 100644
--- a/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemLikeHolder.java
+++ b/common/src/main/java/io/github/slimeistdev/crystalline_sky/foundation/registration/holder/ItemLikeHolder.java
@@ -23,21 +23,12 @@ abstract class ItemLikeHolder<T extends ItemLike> extends BaseHolder<T> implemen
 		return is(stack.getItem());
 	}
 
-	public abstract boolean is(Item item);
+	public boolean is(Item item) {
+		return asItem() == item;
+	}
 
 	@Override
 	public Item asItem() {
 		return value().asItem();
 	}
-
-	static class NonItem<T extends ItemLike> extends ItemLikeHolder<T> {
-		protected NonItem(HolderOwner<T> owner, ResourceKey<T> key) {
-			super(owner, key);
-		}
-
-		@Override
-		public boolean is(Item item) {
-			return asItem() == item;
-		}
-	}
 }